Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ remove object spread operator for faster performance in big array iterator #2812

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Nov 15, 2023

在一个 800 个元素左右的数组迭代里,每次都调用 object spread,会花掉接近 80ms 的 cpu 时间

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Copy link

changeset-bot bot commented Nov 15, 2023

⚠️ No Changeset found

Latest commit: d434d34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qiankun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 8:14am

@kuitos kuitos merged commit e75952f into master Nov 15, 2023
5 checks passed
@kuitos kuitos deleted the optimize/remove-spread branch November 15, 2023 08:19
@dohard-ma
Copy link

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants