feat: insertBefore加入script逻辑 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuitos
requested changes
May 21, 2020
| ); | ||
|
|
||
| const dynamicScriptCommentElement = document.createComment(`dynamic script ${src} replaced by qiankun`); | ||
| return rawAppendChild.call(appWrapperGetter(), dynamicScriptCommentElement) as T; |
kuitos
requested changes
May 21, 2020
| element.onerror, | ||
| ); | ||
| const dynamicInlineScriptCommentElement = document.createComment('dynamic inline script replaced by qiankun'); | ||
| return rawHeadInsertBefore.call(appWrapperGetter(), dynamicInlineScriptCommentElement, refChild) as T; |
There was a problem hiding this comment.
kuitos
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
resolve #590
dynamicHeadAppend.ts中insertBefore加入script处理逻辑