Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ optimize sandbox performance #625

Merged
merged 4 commits into from
Jun 1, 2020
Merged

⚡ optimize sandbox performance #625

merged 4 commits into from
Jun 1, 2020

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Jun 1, 2020 •
edited
Loading

  1. 使用 Symbol.unscopables 机制过滤某些高频的、不会被复写的原生属性的访问操作
  2. 优化若干沙箱内的方法，保证尽可能高的调用性能
  3. 修复 hasOwnProperty 和 bound function 在沙箱场景行为不符合预期的问题，从而避免触发不必要的 UI library rerender
Checklist
  • npm test passes
  • tests are included
  • commit message follows commit guidelines
Description of change

ref #588

This change is Reviewable

@kuitos kuitos requested review from Deturium and howel52 June 1, 2020 13:42
Deturium
Deturium previously approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@Deturium Deturium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

howel52
howel52 previously approved these changes Jun 1, 2020
View reviewed changes
@howel52 howel52 merged commit 2e196d1 into master Jun 1, 2020
@howel52 howel52 deleted the improvement/optimize-performance branch June 1, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howel52 howel52 howel52 approved these changes

@Deturium Deturium Deturium left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuitos @howel52 @Deturium