Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 bootstrapping patch just run once but freer may called repeatedly #652

Merged
merged 1 commit into from
Jun 11, 2020
Merged

🐛 bootstrapping patch just run once but freer may called repeatedly #652

merged 1 commit into from
Jun 11, 2020

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Jun 11, 2020 •
edited
Loading

bootstrap patch 只会执行一次，但是 bootstrap freer function 每次 unmount 都会执行

This change is Reviewable

@kuitos kuitos changed the title 🐛 bootstrapping patch just run once but freer will called repeatedly 🐛 bootstrapping patch just run once but freer may called repeatedly Jun 11, 2020
Deturium
Deturium approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@Deturium Deturium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuitos kuitos merged commit cdeeac9 into master Jun 11, 2020
@kuitos kuitos deleted the fix/patch-count branch June 11, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deturium Deturium Deturium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuitos @Deturium