Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ support patch the dynamic dom appending via document.body.appendChild #667

Merged
merged 2 commits into from
Jun 16, 2020
Merged

✨ support patch the dynamic dom appending via document.body.appendChild #667

merged 2 commits into from
Jun 16, 2020

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Jun 15, 2020 •
edited
Loading

有场景是通过 document.body.appendChild 动态添加 script 的

This change is Reviewable

@kuitos kuitos requested review from Deturium and howel52 June 15, 2020 08:47
howel52
howel52 previously approved these changes Jun 15, 2020
View reviewed changes
@howel52
Copy link
Collaborator

howel52 commented Jun 15, 2020

LGTM

Deturium
Deturium previously approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@Deturium Deturium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件名是不是要改一下了，
dynamicHeadAppend.ts -> dynamicAppend.ts

@kuitos kuitos dismissed stale reviews from Deturium and howel52 via d9f6fe9 June 15, 2020 09:37
@kuitos
Copy link
Member Author

kuitos commented Jun 15, 2020

这个文件名是不是要改一下了，
dynamicHeadAppend.ts -> dynamicAppend.ts

done

@kuitos kuitos requested a review from Deturium June 15, 2020 09:37
@Deturium Deturium merged commit 8cfcfca into master Jun 16, 2020
@Deturium Deturium deleted the feat/support-dynamic-body-append branch June 16, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deturium Deturium Deturium approved these changes

@howel52 howel52 howel52 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuitos @howel52 @Deturium