Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: supplement and improve api documentation #942

Merged
merged 4 commits into from
Sep 21, 2020
Merged

doc: supplement and improve api documentation #942

merged 4 commits into from
Sep 21, 2020

Conversation

gongshun
Copy link
Collaborator

Checklist
  • documentation is changed or added
Description of change
  • 完善 entry 的说明
  • 修正 getPublicPath 的说明
  • 补充 ignore 的说明

@@ -450,3 +451,16 @@ toc: menu
props.setGlobalState(state);
}
```

## 微应用的配置
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分加到 FAQ 或者 cookbook 章节?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块内容写到 api 说明确实不太合适,我先去掉

Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuitos kuitos merged commit ae3c2a1 into master Sep 21, 2020
@kuitos kuitos deleted the fix/doc branch September 21, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants