decrease CppBase rigidity #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit 357d523 can just be reverted when the time comes to not support the old usage anymore |
also fix some whitespace errors
considering it will get built right away, this is informational at most
instead of requiring that the module be defined in one .cpp and .h file named 'module_name' only require the binding_*.cpp, and allow additional source files to be added to the compilation unit. This makes life easier for people who use header-only libraries, and enables binding multiple source files into the same pybind module. If necessary, adding the possibility for further include folders later should be trivial.
this reintroduces the previous usage of binding_class_name, so that updating pymoskito doesn't break old pybinds. a friendly warning is generated, mentioning that this is now deprecated.
TanDro
pushed a commit
that referenced
this pull request
Mar 25, 2022
* do not repeat log/error messages also fix some whitespace errors * lower log level of 'cmakelists not found' considering it will get built right away, this is informational at most * decrease CppBase rigidity instead of requiring that the module be defined in one .cpp and .h file named 'module_name' only require the binding_*.cpp, and allow additional source files to be added to the compilation unit. This makes life easier for people who use header-only libraries, and enables binding multiple source files into the same pybind module. If necessary, adding the possibility for further include folders later should be trivial. * cppbase: deprecate usage of binding_class_name this reintroduces the previous usage of binding_class_name, so that updating pymoskito doesn't break old pybinds. a friendly warning is generated, mentioning that this is now deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits starts out with some general improvements, then improves
CppBases flexibility, and finally reenables current usage of the class.This could still be simplified further, all the while increasing flexibility, but I expect this to be a nice middle ground between still guiding unknowledgeable users, while not hindering others.
I could also update the pymoskito examples to use the undeprecated arguments of
CppBaseif this is desired