Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decrease CppBase rigidity #10

Merged
merged 4 commits into from
Mar 25, 2022
Merged

decrease CppBase rigidity #10

merged 4 commits into from
Mar 25, 2022

Commits on Feb 16, 2022

  1. do not repeat log/error messages 

    also fix some whitespace errors
    @jhalmen
    jhalmen committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    bdd61db View commit details
    Browse the repository at this point in the history

  2. lower log level of 'cmakelists not found' 

    considering it will get built right away, this is informational at most
    @jhalmen
    jhalmen committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    ae934d2 View commit details
    Browse the repository at this point in the history

  3. decrease CppBase rigidity 

    instead of requiring that the module be defined in one .cpp and .h file
named 'module_name' only require the binding_*.cpp, and allow additional
source files to be added to the compilation unit.
This makes life easier for people who use header-only libraries, and
enables binding multiple source files into the same pybind module.

If necessary, adding the possibility for further include folders later
should be trivial.
    @jhalmen
    jhalmen committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    226a45f View commit details
    Browse the repository at this point in the history

  4. cppbase: deprecate usage of binding_class_name 

    this reintroduces the previous usage of binding_class_name, so that
updating pymoskito doesn't break old pybinds.
a friendly warning is generated, mentioning that this is now deprecated.
    @jhalmen
    jhalmen committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    357d523 View commit details
    Browse the repository at this point in the history