Each subclass was triggering code injection for it's parent class #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aforward
reviewed
Sep 24, 2016
| { | ||
| prepareCodeInjectionForAttribute(aClass, av); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you ensure all indentation are spaces (2 for an indent). I am seeing some tabs in this PR
There was a problem hiding this comment.
Sure, I'll update when I get a chance.
I'm used to using tabs, sorry.
|
I'm not bothered by the appveyor failing on the PR. It passed on the branch. That should be good enough to merge, but I will leave it to Vahdat |
|
@TimLethbridge I was trying to understand the issue. We somehow need to know why this happens. It shows the error related to getting http://downloads.sourceforge.net/project/simpletest/simpletest/simpletest_1.1/simpletest_1.1.0.tar.gz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: By submitting a patch, you agree that your work will be licensed under the license used by the project.
If your pull request does not pass CI, it will not be merged (unless heavily justified).
Description
Please provide a description of what this PR is meant to fix, and how it works (if it's not clear from the code changes).
Tests
Please list all major test changes. All issues should have a test created to address the issue in the future (as relevant).
If closing issues, please write
Closes #ISSUE_NUMBER[, #ISSUE_NUMBER2, ...], to automatically close the equivalent issue.Note: This template is a guide, remove sections as applicable.