Fix issue 923 #978
Merged
Fix issue 923 #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update state_machine_Event.ump to check if the event implements an interface method * Add test case for when the state machine fully implements an interface * Add test case for when the state machine partially implements an interface * Add test case for when the state machine does not implement an interface
* Update state_machine_Event.ump to check if the event implements an interface method
* Add test case for when the state machine fully implements an interface
* Add test case for when the state machine partially implements an interface
* Add test case for when the state machine does not implement an interface
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #923 by modifying the state_machine_Event.ump template for both Java and PHP generated code. This template now checks if an event implements an interface method. For Java, the "@OverRide" directive is placed on top of the event's method if it implements an interface method. On my Mac, the full build is successful.
Tests
Added the following tests to "PhpClassTemplateTest.java" and "JavaClassTemplateTest.java" to check the generated PHP and Java code for when a state machine implements all, some, or none of the methods in an interface.
StateMachineImplementsInterface
Umple File: ClassTemplateTest_StateMachineImplementsInterface.ump
StateMachineImplementsPartialInterface
Umple File: ClassTemplateTest_StateMachineImplementsPartialInterface.ump
StateMachineDoesNotImplementInterface
Umple File: ClassTemplateTest_StateMachineDoesNotImplementInterface.ump
For the PHP tests, none of the methods in the .ump files include parameters since issue #964 is still being fixed.