Fix #483 issue for Umple #994
Conversation
cruise.umple/src/Main_Code.ump
Outdated
| //t0 repersents model run start time while t1 represents end time | ||
| Double t0 = 0.0; | ||
| Double t1 = 0.0; | ||
|
|
There was a problem hiding this comment.
I would suggest changing names to ones which are more meaningful.
For example, startTime and endTime
cruise.umple/src/Umple_Code.ump
Outdated
| //gTime2 represents code generation end time | ||
| Double t11 = 0.0; | ||
| Double gTime1 = 0.0; | ||
| Double gTime2 = 0.0; |
There was a problem hiding this comment.
again use relevant names for variables. You can also use proper modifiers for those variables. for example, tParsingTime for the parsing time.
cruise.umple/src/Umple_Code.ump
Outdated
| String parsingT = String.valueOf(t11); | ||
| return parsingT; | ||
| } | ||
|
|
There was a problem hiding this comment.
You don't need to define this method. If you give a proper name to the variable, Umple will generate this method automatically.
cruise.umple/src/Main_Code.ump
Outdated
| @@ -292,6 +318,7 @@ class UmpleConsoleMain | |||
|
|
|||
| String languages = String.join(",", UmpleModel.validLanguages ); | |||
| optparser.acceptsAll(Arrays.asList("version", "v"), "Print out the current Umple version number"); | |||
| optparser.acceptsAll(Arrays.asList("performance", "p"), "Indicate time to generate files"); | |||
There was a problem hiding this comment.
change this Indicate time to generate files with the following one:
Indicate time taken to parse and generate code
Jaorji
force-pushed
the
Fix-#483
branch
4 times, most recently
from
ecc1edd
to
d5bc25f
Compare
cruise.umple/src/Umple_Code.ump
Outdated
| //gTime1 represents code generation start time | ||
| //gTime2 represents code generation end time | ||
| Double parsingTime = 0.0; | ||
| Double gTime1 = 0.0; |
There was a problem hiding this comment.
gTime1 and gTime2 must be indicated as internal. The reason is that there is no need to them to be available through an instance of UmpleModel
|
@Jaorji good job. Thanks. |
The test failed.The error message is:
cinst ant 2>&1 | Out-Null
cinst php --version=5.6.29 2>&1 | Out-Null
Command exited with code 1