Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ukrainian locale #1104

Merged
merged 8 commits into from
Aug 20, 2021
Merged

Conversation

gatezh
Copy link
Contributor

@gatezh gatezh commented Aug 16, 2021

  • Add new translations
  • Fix translation mistakes / inconsistencies

@gatezh gatezh requested a review from umputun as a code owner August 16, 2021 02:38
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #1104 (91aa459) into master (f0ae4b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1104   +/-   ##
=======================================
  Coverage   47.38%   47.38%           
=======================================
  Files         134      134           
  Lines        2942     2942           
  Branches      658      658           
=======================================
  Hits         1394     1394           
  Misses       1538     1538           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ae4b6...91aa459. Read the comment docs.

@paskal
Copy link
Sponsor Collaborator

paskal commented Aug 16, 2021

@umputun sorry, I don't speak Ukrainian and can't review it.

frontend/app/locales/ua.json Outdated Show resolved Hide resolved
frontend/app/locales/ua.json Outdated Show resolved Hide resolved
frontend/app/locales/ua.json Outdated Show resolved Hide resolved
frontend/app/locales/ua.json Outdated Show resolved Hide resolved
frontend/app/locales/ua.json Outdated Show resolved Hide resolved
@paskal paskal removed their request for review August 16, 2021 18:15
frontend/app/locales/ua.json Outdated Show resolved Hide resolved
frontend/app/locales/ua.json Show resolved Hide resolved
frontend/app/locales/ua.json Outdated Show resolved Hide resolved
frontend/app/locales/ua.json Outdated Show resolved Hide resolved
frontend/app/locales/ua.json Outdated Show resolved Hide resolved
gatezh and others added 7 commits August 16, 2021 20:35
Co-authored-by: Eugene <ievgenteslia@gmail.com>
Co-authored-by: Eugene <ievgenteslia@gmail.com>
Co-authored-by: Eugene <ievgenteslia@gmail.com>
Co-authored-by: Eugene <ievgenteslia@gmail.com>
Co-authored-by: Eugene <ievgenteslia@gmail.com>
@gatezh
Copy link
Contributor Author

gatezh commented Aug 20, 2021

Applied all of the feedback. Ready for another review

Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the code are applied correctly ;)

@umputun umputun merged commit 9f6c766 into umputun:master Aug 20, 2021
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants