Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make TestService_UserReplies more robust #1122

Merged
merged 1 commit into from
Sep 4, 2021
Merged

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Sep 4, 2021

It flaps (see #380), and with this change, it will have more time to get the expected output in the flaky GitHub Actions environment.

The latest example of false positive: link.

@paskal paskal added the backend label Sep 4, 2021
@paskal paskal requested a review from umputun September 4, 2021 09:00
@paskal paskal force-pushed the paskal/test_user_replies branch 2 times, most recently from c26808f to ee9e292 Compare September 4, 2021 09:11
@paskal paskal marked this pull request as draft September 4, 2021 09:11
@coveralls
Copy link

coveralls commented Sep 4, 2021

Pull Request Test Coverage Report for Build 1200637388

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 83.702%

Files with Coverage Reduction New Missed Lines %
backend/app/notify/notify.go 2 94.34%
Totals Coverage Status
Change from base Build 1191515627: 0.0%
Covered Lines: 5752
Relevant Lines: 6872

💛 - Coveralls

@paskal paskal marked this pull request as ready for review September 4, 2021 09:14
It flaps (see #380), and with this change, it will
have more time to get the expected output in
the flaky GitHub Actions environment.
@umputun umputun merged commit bb3c862 into master Sep 4, 2021
@umputun umputun deleted the paskal/test_user_replies branch September 4, 2021 17:44
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants