Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty user's comments should return 200 instead of 400 #1270

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

umputun
Copy link
Owner

@umputun umputun commented Feb 10, 2022

Currently, a perfectly valid request for a user without comments returns 400, which is misleading as the lack of comments is not an indication of any error.

Instead, we should return 200 and an empty list, see #1265

@umputun umputun merged commit 7b47bd2 into master Feb 10, 2022
@umputun umputun deleted the user-comments-empy-200 branch February 10, 2022 21:31
@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants