Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix positive_score and low_score comments options #1337

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Apr 22, 2022

  • enable downvoting for only positive. it should give ability to downvote until score is 0
  • restore low_score state of a comment. it should make comment semi transparent when downvoted

@akellbl4 akellbl4 requested a review from Mavrin April 22, 2022 01:23
@akellbl4 akellbl4 requested a review from umputun as a code owner April 22, 2022 01:23
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1337 (e41d16e) into master (bf6a08b) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
+ Coverage   50.18%   50.19%   +0.01%     
==========================================
  Files         139      139              
  Lines        3003     3008       +5     
  Branches      683      690       +7     
==========================================
+ Hits         1507     1510       +3     
- Misses       1484     1486       +2     
  Partials       12       12              
Impacted Files Coverage Δ
frontend/app/components/comment/comment.tsx 60.71% <66.66%> (+0.16%) ⬆️
frontend/app/components/comment/comment-votes.tsx 95.55% <100.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6a08b...e41d16e. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 22, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 100 ms (-0.1% 🔽) 141 ms
public/remark.mjs 65.87 KB (+0.06% 🔺) 1.4 s (+0.06% 🔺) 177 ms (-27.8% 🔽) 1.5 s
public/remark.css 8.17 KB (+0.02% 🔺) 164 ms (+0.02% 🔺) 0 ms (+100% 🔺) 164 ms
public/last-comments.mjs 31.95 KB (+0.12% 🔺) 639 ms (+0.12% 🔺) 195 ms (+17.42% 🔺) 834 ms
public/last-comments.css 3.78 KB (0%) 76 ms (0%) 0 ms (+100% 🔺) 76 ms
public/deleteme.mjs 9.92 KB (0%) 199 ms (0%) 108 ms (-12.76% 🔽) 307 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 103 ms (-21.15% 🔽) 118 ms

@akellbl4 akellbl4 changed the title enable downvoting for only positive fix positive_score and low_score comments options Apr 22, 2022
@umputun umputun merged commit 21d0339 into master Apr 25, 2022
@umputun umputun deleted the fix-only-positive branch April 25, 2022 01:19
@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants