Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api sdk #1390

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Add api sdk #1390

merged 1 commit into from
Aug 20, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jun 19, 2022

adds an alpha version of package with JS API client

https://www.npmjs.com/package/@remark42/api

future improvements:

@paskal
Copy link
Sponsor Collaborator

paskal commented Jun 19, 2022

Please don't forget to alter that document.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

size-limit report 📦

Path Size
public/embed.mjs 2.02 KB (0%)
public/remark.mjs 72.37 KB (+0.01% 🔺)
public/remark.css 8.2 KB (0%)
public/last-comments.mjs 35.51 KB (0%)
public/last-comments.css 3.79 KB (-0.03% 🔽)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@akellbl4 akellbl4 mentioned this pull request Jul 11, 2022
@akellbl4 akellbl4 changed the base branch from master to use-packages July 11, 2022 03:12
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1390 (ffb786b) into master (75427df) will increase coverage by 28.70%.
The diff coverage is 86.83%.

@@             Coverage Diff             @@
##           master    #1390       +/-   ##
===========================================
+ Coverage   58.12%   86.83%   +28.70%     
===========================================
  Files         131        8      -123     
  Lines        2909      509     -2400     
  Branches      743       67      -676     
===========================================
- Hits         1691      442     -1249     
+ Misses       1214        0     -1214     
- Partials        4       67       +63     
Impacted Files Coverage Δ
frontend/packages/api/consts.ts 63.63% <63.63%> (ø)
frontend/packages/api/lib/cookies.ts 63.63% <63.63%> (ø)
frontend/packages/api/lib/fetcher.ts 80.85% <80.85%> (ø)
frontend/packages/api/clients/auth.ts 82.97% <82.97%> (ø)
frontend/packages/api/clients/admin.ts 85.07% <85.07%> (ø)
frontend/packages/api/clients/public.ts 92.81% <92.81%> (ø)
frontend/packages/api/clients/index.ts 96.36% <96.36%> (ø)
frontend/packages/api/index.ts 100.00% <100.00%> (ø)
.../comment-form/markdown-toolbar-icons/code-icon.tsx
...end/apps/remark42/app/components/thread/thread.tsx
... and 129 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@akellbl4 akellbl4 force-pushed the add-api-sdk branch 4 times, most recently from cf6e476 to e7fb04e Compare July 11, 2022 07:28
@akellbl4 akellbl4 requested a review from Mavrin July 11, 2022 07:28
@akellbl4 akellbl4 marked this pull request as ready for review July 11, 2022 07:30
@akellbl4 akellbl4 requested a review from umputun as a code owner July 11, 2022 07:30
@akellbl4 akellbl4 marked this pull request as draft July 12, 2022 17:12
@akellbl4 akellbl4 force-pushed the use-packages branch 4 times, most recently from 579e4a5 to 7d5783e Compare July 15, 2022 00:44
@akellbl4 akellbl4 force-pushed the add-api-sdk branch 4 times, most recently from 22a53e1 to 21bc43e Compare July 18, 2022 01:08
@akellbl4 akellbl4 force-pushed the use-packages branch 2 times, most recently from e3e9b85 to f2e7de0 Compare July 22, 2022 01:02
@paskal paskal force-pushed the add-api-sdk branch 2 times, most recently from 0a15cd3 to 2e8644c Compare July 22, 2022 01:42
Base automatically changed from use-packages to master July 29, 2022 16:05
@akellbl4 akellbl4 force-pushed the add-api-sdk branch 8 times, most recently from 4d60d53 to 5f376b1 Compare August 20, 2022 06:11
@akellbl4 akellbl4 marked this pull request as ready for review August 20, 2022 06:13
@akellbl4
Copy link
Collaborator Author

@Mavrin let's merge it and I could test it properly by using in the app itself. After it we can do publish/docs and rest of the stuff.

@umputun umputun merged commit b47b6c4 into master Aug 20, 2022
@umputun umputun deleted the add-api-sdk branch August 20, 2022 17:58
@paskal paskal added this to the v1.10.2 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants