Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve frontend configuration parameters documentation #1571

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Jan 8, 2023

Variables were documented in the documentation but not in the code, and max_last_comments needed to be documented.

Resolved #764.

Variables were documented in the documentation but not in the code,
and max_last_comments needed to be documented.
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Base: 58.05% // Head: 58.05% // No change to project coverage 👍

Coverage data is based on head (3534e87) compared to base (82f27e6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1571   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files         131      131           
  Lines        2911     2911           
  Branches      736      736           
=======================================
  Hits         1690     1690           
  Misses       1090     1090           
  Partials      131      131           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.76 KB (0%)
public/remark.css 8.12 KB (0%)
public/last-comments.mjs 35.67 KB (0%)
public/last-comments.css 3.72 KB (0%)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@paskal paskal requested a review from Mavrin January 8, 2023 20:17
@paskal paskal merged commit 6616541 into master Jan 10, 2023
@paskal paskal deleted the paskal/improve_frontend_variables_docs branch January 10, 2023 22:53
@paskal paskal added this to the v1.11.3 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme for frontend configuration doesn't show default values
4 participants