Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapped errors checks #1682

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix wrapped errors checks #1682

merged 1 commit into from
Oct 11, 2023

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Oct 10, 2023

As errors can be wrapped in recent versions of Go, the proper way to check the error types are errors.As and errors.Is.

As errors can be wrapped in recent versions of Go, the proper way
to check the error types are `errors.As` and `errors.Is`.
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Pull Request Test Coverage Report for Build 6476003936

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 84.23%

Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/app/main.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
backend/app/notify/notify.go 2 94.55%
Totals Coverage Status
Change from base Build 6472903539: -0.01%
Covered Lines: 5811
Relevant Lines: 6899

💛 - Coveralls

@umputun umputun merged commit 69b18d3 into master Oct 11, 2023
4 checks passed
@umputun umputun deleted the paskal/err_fix branch October 11, 2023 04:36
@paskal paskal added this to the v1.13.0 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants