Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for value for refresh token cache #1754

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Mar 22, 2024

It was set to string by mistake, and the proper type is token.Claims.

The bug was in action from 1313dee from February 20 (unreleased, just in the master branch) and resulted in 500 error while calling /config endpoint due to the conversion failure:

[INFO]  request panic for /api/v1/config?site=remark42 from *.*.*.*, interface conversion: interface {} is token.Claims, not string

It was set to string by mistake, proper type is token.Claims.
@paskal paskal requested a review from umputun as a code owner March 22, 2024 09:12
@umputun umputun merged commit e0423b8 into master Mar 22, 2024
4 checks passed
@umputun umputun deleted the paskal/fix_refresh_tokens_cache branch March 22, 2024 09:16
@paskal paskal added this to the v1.13.0 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants