On-demand auth #616
Merged
On-demand auth #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* auth block was moved to comment form * if comments on page read only auth form shows in old place * comment value in form will be saved between refreshes (it is side effect form saving comment value between unauth and auth states)
akellbl4
force-pushed
the
on-demand-auth
branch
from
dcb5a53
to
379b23c
Compare
paskal
previously approved these changes
Mar 11, 2020
|
looking good. So far the only thing I run into - image drag-drop (cut-paste) doesn't work in the entry box unless the user logged in. I understand this is due to the required auth for image operation, but user can be surprised. Maybe we should show some message saying "to add image pls login" or smth like this |
Mavrin
reviewed
Mar 12, 2020
Mavrin
previously approved these changes
Mar 12, 2020
|
@akellbl4 - do you want me to merge it in or still work in progress? |
|
@umputun I think I should add notification about image uploading before merge. |
makes sense. |
|
the error message should disappear after the login |
Mavrin
requested changes
Mar 12, 2020
|
@Mavrin done |
Mavrin
approved these changes
Mar 12, 2020
umputun
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solve suggestions form #595 and #426
It is fast realization of on-demand auth.
I can have small bugs and maybe not so clean code.
I will happy with any suggestions connected with realization.
P.S. Auth block needs to refactor and maybe small redesign, I plan to do it in the near feature.
Screenshots
Top comment block:
Comment block under any comment:
Read only page:
