Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations for Japanese, Korean, Brazilian Portuguese #969

Merged
merged 2 commits into from
May 3, 2021
Merged

Add translations for Japanese, Korean, Brazilian Portuguese #969

merged 2 commits into from
May 3, 2021

Conversation

dmitry-do
Copy link
Contributor

@dmitry-do dmitry-do commented May 3, 2021

Add translations for

  • Japanese (ja.json)
  • Korean (ko.json)
  • Brazilian Portuguese (bp.json)

WIP This PR requires generating the code to enable the translations properly as described in How to add a new translation (details)

@dmitry-do dmitry-do requested a review from umputun as a code owner May 3, 2021 16:48
@dmitry-do dmitry-do mentioned this pull request May 3, 2021
@umputun umputun requested a review from akellbl4 May 3, 2021 17:59
Dmitry K and others added 2 commits May 3, 2021 21:49
Add translations for Japanese, Korean, Brazilian Portuguese

note: This PR requires generating the code to enable them properly as described in [How to add a new translation](https://remark42.com/docs/latest/translation/#how-to-add-a-new-translation)
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #969 (3f575a4) into master (4bae705) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   43.19%   43.19%           
=======================================
  Files         127      127           
  Lines        2623     2623           
  Branches      519      519           
=======================================
  Hits         1133     1133           
  Misses       1444     1444           
  Partials       46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bae705...3f575a4. Read the comment docs.

Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitry-konchalenkov thank you and @JetBrains for three new langs in Remark42!

Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@umputun umputun merged commit d1405ac into umputun:master May 3, 2021
@paskal paskal added this to the v1.8 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants