Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations #968

Merged
merged 7 commits into from
May 3, 2021
Merged

Update translations #968

merged 7 commits into from
May 3, 2021

Conversation

dmitry-do
Copy link
Contributor

@dmitry-do dmitry-do commented May 3, 2021

Update translations for

  • German
  • Spanish
  • French
  • Russian
  • Turkish
  • Chinese (Simplified)

Dmitry K added 4 commits May 3, 2021 13:18
Update translations for 
- Brazilian Portuguese (`bp.json`) // Not used at the moment, would be nice to support it in [loadLocale.ts](https://github.com/umputun/remark42/blob/master/frontend/app/utils/loadLocale.ts)
- German, 
- Spanish, 
- French, 
- Japanese, 
- Korean, 
- Russian
- Turkish
- Chinese (Simplified)
Update translations for 
- German, 
- Spanish
- French
- Japanese 
- Russian
- Turkish
- Chinese (Simplified)
- Brazilian Portuguese (`bp.json`) // Not used at the moment; would be nice to add support for it in [loadLocale.ts](https://github.com/umputun/remark42/blob/master/frontend/app/utils/loadLocale.ts)
- Korean (`ko.json`)  // Not used at the moment; would be nice add support for it in [loadLocale.ts](https://github.com/umputun/remark42/blob/master/frontend/app/utils/loadLocale.ts)
@dmitry-do dmitry-do requested a review from umputun as a code owner May 3, 2021 10:48
@paskal
Copy link
Sponsor Collaborator

paskal commented May 3, 2021

Do you possess these languages or used machine translations to update them?

Also, would you be so kind as to move new languages into separate MR and generate the code to enable them properly in it? For new languages, the mere presence is better than the lack of the language, so we'll merge them quickly. For existing languages changes, we'll need to check if the new translations are better than the existing ones, which will require more effort from reviewers and will take more time.

@dmitry-do
Copy link
Contributor Author

Hi @paskal,

Do you possess these languages or used machine translations to update them?

These translations were carried out by professional translators (native speakers) within JetBrains. :)

Also, would you be so kind as to move new languages into separate MR and generate the code to enable them properly in it?

Sure, I've removed new translations from this PR and created #969 (Add translations for Japanese, Korean, Brazilian Portuguese). Unfortunately I don't have Docker/npm on my machine, perhaps someone from the community will be able to use #969 and add new translations at some point. Thanks!

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #968 (5cf0fd1) into master (b748771) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   43.19%   43.19%           
=======================================
  Files         127      127           
  Lines        2623     2623           
  Branches      519      519           
=======================================
  Hits         1133     1133           
  Misses       1444     1444           
  Partials       46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b748771...5cf0fd1. Read the comment docs.

@akellbl4 akellbl4 linked an issue May 3, 2021 that may be closed by this pull request
14 tasks
Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitry-konchalenkov thank you for such contribution!

Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work, thx

@umputun umputun merged commit 4bae705 into umputun:master May 3, 2021
@paskal paskal added this to the v1.8 milestone Jan 15, 2022
@dmitry-do dmitry-do mentioned this pull request May 9, 2022
@dmitry-do dmitry-do mentioned this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization for new strings in UI
4 participants