Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make form available after failed commit sending #981

Merged
merged 2 commits into from
May 6, 2021

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented May 5, 2021

Resolves #965

  • add a new error code on the server for proper indication on the frontend
  • simplify errors map on the frontend in favor of simple and small code

@akellbl4 akellbl4 requested review from umputun, paskal and Mavrin May 5, 2021 21:43
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #981 (59d6499) into master (82f8f6c) will decrease coverage by 0.02%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
- Coverage   43.17%   43.14%   -0.03%     
==========================================
  Files         127      127              
  Lines        2622     2612      -10     
  Branches      519      514       -5     
==========================================
- Hits         1132     1127       -5     
+ Misses       1444     1439       -5     
  Partials       46       46              
Impacted Files Coverage Δ
...ntend/app/components/comment-form/comment-form.tsx 46.44% <ø> (ø)
frontend/app/utils/errorUtils.ts 50.00% <40.00%> (ø)
frontend/app/common/fetcher.ts 94.64% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e841bc2...59d6499. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 5, 2021

size-limit report 📦

Path Size
public/embed.mjs 2.28 KB (0%)
public/remark.mjs 67.18 KB (-0.29% 🔽)
public/remark.css 10.62 KB (0%)
public/last-comments.mjs 30.91 KB (-0.6% 🔽)
public/last-comments.css 5.76 KB (0%)
public/deleteme.mjs 9.96 KB (-1.51% 🔽)
public/counter.mjs 626 B (0%)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 814863324

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.564%

Totals Coverage Status
Change from base Build 812645973: 0.0%
Covered Lines: 5364
Relevant Lines: 6419

💛 - Coveralls

@akellbl4 akellbl4 added this to the v1.9 milestone May 5, 2021
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend change makes sense

@umputun umputun merged commit 5782495 into master May 6, 2021
@umputun umputun deleted the 965-fix-error-on-restricted-words branch May 6, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid comments cannot be corrected and send
4 participants