-
Notifications
You must be signed in to change notification settings - Fork 7
upload #137
base: master
Are you sure you want to change the base?
upload #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core doesn't build, it says:
Compiling TypeScript sources through ngc
ERROR: projects/wave-core-new/src/lib/datasets/dataset.service.ts:27:58 - error TS2304: Cannot find name 'DataSetIdDict'.27 createDataSet(create: CreateDataSetDict): Observable {
Unfortunately, our core-new is not part of our CI-build-run. Maybe you can add it to package.json > build ?
projects/wave-core-new/src/lib/datasets/add-data/add-data.component.ts
Outdated
Show resolved
Hide resolved
projects/wave-core-new/src/lib/datasets/upload/upload.component.ts
Outdated
Show resolved
Hide resolved
projects/wave-core-new/src/lib/datasets/upload/upload.component.ts
Outdated
Show resolved
Hide resolved
projects/wave-core-new/src/lib/datasets/upload/upload.component.ts
Outdated
Show resolved
Hide resolved
projects/wave-core-new/src/lib/datasets/upload/upload.component.ts
Outdated
Show resolved
Hide resolved
|
Angular 11 Migration
|
the process consists of multiple steps, each step is a card. As inputing raw loading info is not user friendly we will rework this dialog anyway.
Yeah the "browse" is not a button but a file-input which looks different in every browser and for each language. This needs a separate component. may be a good hiwi-task
we won't ever ask the user to input the raw loading info. We will have to implement custom dialogs for different types of upload. But this is not in the scope of this task
The textbox will never be user by real users so no need to style it. In my browser it looks fine ;)
should happen instantaneously. Do we have loading indicators for create layer buttons (aside from the layer list)?
Yeah I thought about showing a "add data set to map" button after the data set was created. But I guess in reality you want to go to the "Add data" menu automatically and highlight the new dataset there. But this I cannot do yet and is outside of the scope of the task
It worked for ports and NDVI for me. There are many pitfalls when specifying the loading info directly. So maybe try them or give me the data you used and I can look at the problem..
it takes the name in the json and worked for me... please give me the data so I can reproduce it
Nice idea. Could be the next task in the story. |
No description provided.