-
Notifications
You must be signed in to change notification settings - Fork 276
Conversation
This change also fixes a todo with the naming of the LCM messages section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these tiny commits be squashed together?
No. I will squash at the end. Up until then it won't matter. We can discuss this more offline if you'd like. It will also be laid out in the new workflow doc which I am concurrently working on. This change is for the example there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two code comments that need revision. Additionally, this pull request does not address the fourth action item in #431 , which is to include the hotkeys from FieldItems.vue
You're right! That should definitely be a part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments! Looks good to squash and merge
resolves #431
Add a wiki detailing what each hotkey does as well as what file that hotkey is implemented.
This changes was tested by viewing the wiki on my fork to verify it rendered properly.