Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace default configuration file location #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dvzrv
Copy link
Contributor

@dvzrv dvzrv commented Feb 24, 2021

src/config.h.in:
Namespace the default configuration file location with the project's
name "umurmur", as in that location also the required certificates are
expected by default and using a namespaced location makes sense as to
not clutter the SYSCONFDIR (e.g. /etc/) with more files, as a namespace
is necessary anyways.

CMakeLists.txt:
Install the default configuration file to a "umurmur" namespaced
location.

Fixes #169

src/config.h.in:
Namespace the default configuration file location with the project's
name "umurmur", as in that location also the required certificates are
expected by default and using a namespaced location makes sense as to
not clutter the SYSCONFDIR (e.g. /etc/) with more files, as a namespace
is necessary anyways.

CMakeLists.txt:
Install the default configuration file to a "umurmur" namespaced
location.

Fixes umurmur#169
@dvzrv
Copy link
Contributor Author

dvzrv commented Jan 25, 2022

@fatbob313 can this be merged?
From a packaging perspective a namespaced location is the only thing that makes sense, as that way arbitrary configuration related files such as TLS certificates can be added (e.g. in the context of certbot deploy hooks) and made available specifically for the umurmur application while rendering them inaccessible to other applications and users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace default configuration file location
1 participant