Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add toml plugin, use taplo inside instead #314

Merged
merged 22 commits into from Nov 27, 2023
Merged

Conversation

so1ve
Copy link
Member

@so1ve so1ve commented Nov 27, 2023

Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: 2293cca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-toml Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Nov 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@JounQin JounQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@so1ve Really thanks for raising this PR, let's make it happen.

packages/toml/package.json Outdated Show resolved Hide resolved
packages/toml/README.md Outdated Show resolved Hide resolved
packages/toml/src/index.ts Outdated Show resolved Hide resolved
packages/toml/src/index.ts Outdated Show resolved Hide resolved
packages/toml/src/index.ts Outdated Show resolved Hide resolved
@so1ve
Copy link
Member Author

so1ve commented Nov 27, 2023

@JounQin Done

packages/toml/package.json Outdated Show resolved Hide resolved
packages/toml/src/index.ts Outdated Show resolved Hide resolved
packages/toml/src/index.ts Outdated Show resolved Hide resolved
packages/toml/src/index.ts Outdated Show resolved Hide resolved
packages/toml/src/index.ts Outdated Show resolved Hide resolved
packages/toml/src/index.ts Outdated Show resolved Hide resolved
packages/toml/src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: JounQin <admin@1stg.me>
@JounQin
Copy link
Member

JounQin commented Nov 27, 2023

Hi @so1ve, do you want to be a collaborator of this repository or a member of @un-ts organization? Of course, it's OK if you don't want to.

@so1ve
Copy link
Member Author

so1ve commented Nov 27, 2023

I want to be a part of this organization❤️

@JounQin
Copy link
Member

JounQin commented Nov 27, 2023

I want to be a part of this organization❤️

Welcome @so1ve !

packages/toml/src/index.ts Outdated Show resolved Hide resolved
packages/toml/package.json Outdated Show resolved Hide resolved
@JounQin JounQin changed the title feat: add toml plugin feat!: add toml plugin, use taplo inside instead Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ac2b2fb) 88.00% compared to head (2293cca) 87.27%.

Files Patch % Lines
packages/toml/src/index.ts 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   88.00%   87.27%   -0.73%     
==========================================
  Files           8       10       +2     
  Lines         150      165      +15     
  Branches       41       45       +4     
==========================================
+ Hits          132      144      +12     
- Misses         17       20       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin JounQin merged commit 7db8ba4 into un-ts:master Nov 27, 2023
12 of 14 checks passed
@JounQin
Copy link
Member

JounQin commented Nov 27, 2023

Thanks and welcome again, and sorry for my nitpicking.

@JounQin
Copy link
Member

JounQin commented Nov 27, 2023

@so1ve I believe https://github.com/so1ve/prettier-plugin-taplo can be archived and https://www.npmjs.com/package/prettier-plugin-taplo can be deprecated now?

@so1ve so1ve deleted the feat/toml branch November 27, 2023 13:59
@so1ve so1ve restored the feat/toml branch November 27, 2023 13:59
@so1ve so1ve deleted the feat/toml branch November 27, 2023 14:00
@so1ve so1ve restored the feat/toml branch November 27, 2023 14:00
@so1ve so1ve deleted the feat/toml branch November 27, 2023 14:00
@so1ve
Copy link
Member Author

so1ve commented Nov 27, 2023

sorry for my nitpicking

Never mind, now the code quality is much better :)

I believe so1ve/prettier-plugin-taplo can be archived and npmjs.com/package/prettier-plugin-taplo can be deprecated now?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prettier-plugin-toml removes blank lines after comments Move to un-ts/prettier and use taplo
2 participants