Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to sql-formatter v14, remove tabulateAlias and commaPosition options #315

Merged
merged 6 commits into from Nov 27, 2023
Merged

feat: upgrade to sql-formatter v14, remove tabulateAlias and commaPosition options #315

merged 6 commits into from Nov 27, 2023

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Nov 27, 2023

Closes #313

I added // since: '0.17.0', because I'm assuming that this will be released in a new minor-position version, considering that it changes configuration options (current version is prettier-plugin-sql@0.16.0)

Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: 0d75453

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-sql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/sql/README.md Outdated Show resolved Hide resolved
packages/sql/src/index.ts Outdated Show resolved Hide resolved
JounQin and others added 4 commits November 27, 2023 18:41
Co-authored-by: JounQin <admin@1stg.me>
Co-authored-by: JounQin <admin@1stg.me>
Copy link

codesandbox-ci bot commented Nov 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin JounQin changed the title Upgrade to sql-formatter@14.0.0 feat: upgrade to sql-formatter v14, remove tabulateAlias and commaPosition options Nov 27, 2023
@JounQin JounQin enabled auto-merge (squash) November 27, 2023 10:54
@JounQin
Copy link
Member

JounQin commented Nov 27, 2023

Thanks @karlhorky for your contribution!

@JounQin JounQin merged commit ac2b2fb into un-ts:master Nov 27, 2023
10 checks passed
@karlhorky
Copy link
Contributor Author

@JounQin glad to help :) thanks for the quick review and merge!

@karlhorky karlhorky deleted the upgrade-to-sql-formatter-14 branch November 27, 2023 10:56
@JounQin
Copy link
Member

JounQin commented Nov 27, 2023

I'll wait for #314 before releasing, please be a bit patient. ❤️

karlhorky referenced this pull request in sql-formatter-org/sql-formatter Nov 27, 2023
@karlhorky
Copy link
Contributor Author

No problem, thanks! I'll keep an eye on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prettier-plugin-sql: Update to sql-formatter@14?
2 participants