Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(webapp): add dmarc record to the dns page #130

Closed
McPizza0 opened this issue Mar 12, 2024 · 1 comment · Fixed by #158
Closed

feature(webapp): add dmarc record to the dns page #130

McPizza0 opened this issue Mar 12, 2024 · 1 comment · Fixed by #158
Assignees
Labels
advanced Extra attention is needed ready for fix/implementation this issue is ready to be worked on requires design this issue either needs a design focused dev or a design to be submitted before work can begin typescript code is mostly backend/typescript based

Comments

@McPizza0
Copy link
Member

when checking the DNS of a domain
we should also check and verify the dmarc for the domain

we will need to suggest users add the dmarc record
BUT
first we need to check if they have another mail system

if they dont have other email systems set up (no mx records)
then we add the following record
key: _dmarc
value: v=DMARC1; p=quarantine; adkim=s; aspf=s;

if they do have another email system, we have to set the dmarc record to be more relaxed, so we dont block their current systems
key: _dmarc
value: v=DMARC1; p=quarantine; adkim=r; aspf=r;

if they already have a dmarc record on the domain, we should just use that
later we can add a popup to encourage more strict dmarc records

@McPizza0 McPizza0 self-assigned this Mar 12, 2024
@McPizza0 McPizza0 added advanced Extra attention is needed typescript code is mostly backend/typescript based labels Mar 12, 2024
@BlankParticle BlankParticle added requires design this issue either needs a design focused dev or a design to be submitted before work can begin ready for fix/implementation this issue is ready to be worked on labels Mar 17, 2024
@McPizza0 McPizza0 linked a pull request Mar 22, 2024 that will close this issue
16 tasks
McPizza0 added a commit that referenced this issue Mar 22, 2024
AI:
This pull request introduces changes related to domain verification and DNS records handling. The update includes adding support for DMARC records, verifying domain ownership, and checking DNS records for verification status. The changes impact the functionality of verifying domain status and configuring DNS records. These updates aim to improve the domain management process and ensure accurate handling of DNS records. Instructions for testing and the reason behind the change are included in the diff.

---

## What does this PR do?

Fixes #130

## Type of change

<!-- Please mark the relevant points by using [x] -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Chore (refactoring code, technical debt, workflow improvements)
- [ ] Enhancement (small improvements)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## Checklist

<!-- We're starting to get more and more contributions. Please help us making this efficient for all of us and go through this checklist. Please tick off what you did  -->

### Required

- [ ] Read [Contributing Guide](https://github.com/un/inbox/blob/main/CONTRIBUTING.md)
- [ ] Self-reviewed my own code
- [ ] Tested my code in a local environment
- [ ] Commented on my code in hard-to-understand areas
- [ ] Checked for warnings, there are none
- [ ] Removed all `console.logs`
- [ ] Merged the latest changes from main onto my branch with `git pull origin main`
- [ ] My changes don't cause any responsiveness issues

### Appreciated

- [ ] If a UI change was made: Added a screen recording or screenshots to this PR
- [ ] Updated the UnInbox Docs if changes were necessary
@BlankParticle
Copy link
Member

Done in #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced Extra attention is needed ready for fix/implementation this issue is ready to be worked on requires design this issue either needs a design focused dev or a design to be submitted before work can begin typescript code is mostly backend/typescript based
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants