-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test sheet #87
Add test sheet #87
Conversation
</div> | ||
|
||
{# cssgram #} | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Format for using CSSgram is as follows:
<figure class="<class">
<img src="..." alt="...">
</figure>
The class goes on the figure (this is important because <img>
elements can't have pseudo elements and I noticed some of the styling was absent because of this.
Ah I did wonder why some looked a bit off. |
This is an awesome addition to the project. A couple of things:
You rock, by the way! 🎸 |
@@ -0,0 +1,80 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this should be in source/
and be test.twig
All fair points.
Should source/scss/demo-site.scss be moved then?
I can do this in another pr, just want to make this pr for the test sheet only rn.
What do you mean by this?
Haha yeah, it was very quickly hacked up 😆 |
Excellent point that |
Check out #89 -- this should also make it easier to have a test page |
I submitted a PR on your repo @m1 in which I move the test page as a part of the site |
…test-suite Conflicts: site/test/index.html site/test/index.twig
Don't merge this yet, just making a few other changes |
No problem -- I don't have Internet right now but I plan to refactor the site to use twig in another PR later today so don't worry about thay |
Okay that should be everything I think? |
Nice work Miles 👍 |
NB. I made it so the instagram pictures are in /ref just incase instagram remove the pictures from the cssgram account or the person developing the filter has no internet access