Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding #ifdefs that break statements. #1117

Closed
wants to merge 1 commit into from
Closed

Avoiding #ifdefs that break statements. #1117

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 25, 2015

A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.

It might improve code understanding, maintainability and error-proneness.

@xrmx
Copy link
Collaborator

xrmx commented Nov 25, 2015

Il 25/11/2015 23:01, flaviommedeiros ha scritto:

A suggestion to compile entire statements and expressions, as suggested by code
style guidelines from the Linux Kernel and practitioners.

It might improve code understanding, maintainability and error-proneness.

The theory looks good but i find the result code a lot less readable. To make
it more readable i'd create a macro IS_AF_INET_4_6 (or similar) with a different
definition if IPV6 is available or not.

Riccardo Magliocchetti
@rmistaken

http://menodizero.it

@xrmx
Copy link
Collaborator

xrmx commented Dec 1, 2015

@flaviommedeiros what do you think about #1121?

@xrmx
Copy link
Collaborator

xrmx commented Dec 2, 2015

Superseded by 23dda03. Thanks for pointing out the issue!

@xrmx xrmx closed this Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants