Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed segfault on uems->default is NULL #972

Closed
wants to merge 1 commit into from
Closed

Fixed segfault on uems->default is NULL #972

wants to merge 1 commit into from

Conversation

swuecho
Copy link

@swuecho swuecho commented Jul 18, 2015

the format of my change is not quite right, I try to get it right, but failed.

when uems->defaults is NULL, mongo::fromjson will segfault.

BTW, what does the defaults in uems->defaults mean? thanks.

@unbit
Copy link
Owner

unbit commented Jul 18, 2015

Honestly i do not remember what defaults is, maybe @WeirdCarrotMonster could help ?

@WeirdCarrotMonster
Copy link
Contributor

uems->defaults provide default values for emperor attributes. I should have set them to empty dict by default and add few checks for value type.

@swuecho
Copy link
Author

swuecho commented Jul 22, 2015

Thanks. Could you take a look at my pull request or find a better fix? @WeirdCarrotMonster

@xrmx
Copy link
Collaborator

xrmx commented Oct 4, 2015

@swuecho Does this patch works for you? xrmx@132a90c

@swuecho
Copy link
Author

swuecho commented Oct 5, 2015

@xrmx Should work. Thanks.

@xrmx
Copy link
Collaborator

xrmx commented Oct 14, 2015

@swuecho Fixed in git master 71d6572

@xrmx xrmx closed this Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants