-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(trezor): Upgrade Trezor Connect to v9 #74
chore(trezor): Upgrade Trezor Connect to v9 #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a new package.json with @trezor/connect-web. Can I run this UI that you screenshotted locally? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled in the latest change and tried again, but I'm still seeing the same This package is not suitable to work with browser. Use @trezor/connect-web package instead
error.
The screenshot is from running Caravan, our open-source multisig coordinator, locally on my machine. You should also be able to run it locally and (hopefully) recreate the issue yourself by following these steps:
The issue I run into is after Caravan spins up, I try to detect a hardware device or start the test suite, and it throws the error immediately, rather than letting me proceed. cc @waldenraines in case the above doesn't make sense. |
src/trezor.test.js
Outdated
@@ -23,7 +23,7 @@ import { | |||
} from "./trezor"; | |||
import {ECPair, payments} from "bitcoinjs-lib"; | |||
|
|||
const TrezorConnect = require("trezor-connect").default; | |||
const TrezorConnect = require("@trezor/connect").default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be importing connect web?
Thanks for the tip @waldenraines. I pushed a change. Would you mind trying the tests again @Rob-Ferguson, I have looked into running that UI you detailed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled down the latest commit, rebuilt everything, and started Caravan locally again. This time, I was able to run through the entire test suite with a Trezor Model 1 without issue. 🎉
I noticed when the Trezor connect window would pop up that it did appear to be referencing the new version 9 - i.e., connect.trezor.io/9 instead of connect.trezor.io/8.
Misread your message, sorry! |
Hi @Rob-Ferguson, |
travis integration seems to be broken at the moment, but i built this PR locally and confirmed it passed tests |
Quick POC of integrating Trezor Connect v9 beta.
v9 Docs: https://github.com/trezor/trezor-suite/tree/develop/packages/connect