Bookmark fix #564
Merged
Bookmark fix #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've refactored this a little: bookmark mutation only allows as long as there is not multiple bookmarks of a product, else it fails and throws an error. createBookmark and removeBookmark are kept like done by you mike. the idea should be: if you use meta, don't use bookmark |
pozylon
added a commit
that referenced
this pull request
Jul 3, 2023
commit d307ab0 Merge: a137b3d 4bce9be Author: Pascal Kaufmann <kaufmae@me.com> Date: Mon Jul 3 22:14:00 2023 +0200 Merge pull request #571 from unchainedshop/fix-removal-of-historic-order-positions Make sure to only remove order positions of orders that are draft commit 4bce9be Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon Jul 3 22:10:01 2023 +0200 Emit events commit 2ddb075 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon Jul 3 21:45:17 2023 +0200 Rebuild without using api commit 3a2fd4e Author: Pascal Kaufmann <pascal@unchained.shop> Date: Wed May 31 08:00:36 2023 +0200 Make sure to only remove order positions of orders that are draft commit a137b3d Merge: e0dc6f0 cc56a5c Author: Pascal Kaufmann <kaufmae@me.com> Date: Mon Jul 3 18:03:43 2023 +0200 Merge pull request #564 from unchainedshop/bookmark-fix Bookmark fix commit cc56a5c Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon Jul 3 17:40:58 2023 +0200 Change types for bookmark to be consistent commit a5d967b Author: Pascal Kaufmann <pascal@unchained.shop> Date: Fri Jun 30 09:00:50 2023 +0200 Harden against duplicates commit 3107023 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Sun Jun 11 19:55:45 2023 +0300 Fix bookmark event and extend mutation.bookmark to accept meta commit e0dc6f0 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon Jul 3 18:00:10 2023 +0200 Also show options that have 0 product count when those are selected commit 3693631 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon Jun 26 16:55:22 2023 +0200 Fix reviews should not be deleted during an upsertion inflicted product removal when a product already exists # Conflicts: # packages/core-products/src/module/configureProductsModule.ts # packages/types/products.ts commit ef793fe Author: Pascal Kaufmann <pascal@unchained.shop> Date: Thu Jun 22 16:14:10 2023 +0200 Fix update token ownership job to not fetch the guests commit 842c0b2 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon Jun 19 23:43:29 2023 +0200 Fix types of pricing directors commit cde503f Author: Pascal Kaufmann <pascal@unchained.shop> Date: Thu Jun 15 10:36:23 2023 +0200 Support null production to signal dispatch estimation that a certain calculation is not possible commit a3fcda8 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Sun Jun 11 07:40:14 2023 +0200 Fix attachment preview for emails with absolute paths to files commit 1ff6d91 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Thu Jun 8 14:04:01 2023 +0200 v2.2.3 commit 862c858 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Thu Jun 8 13:58:14 2023 +0200 Improve the changelog commit cead8ca Author: Pascal Kaufmann <pascal@unchained.shop> Date: Thu Jun 8 13:48:29 2023 +0200 Move platform type defs to platform package, support retryInput commit d394685 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Thu Jun 8 12:44:01 2023 +0200 Allow input fn to skip a planned autoscheduled work commit 6cf0d6b Author: Pascal Kaufmann <pascal@unchained.shop> Date: Thu Jun 8 11:32:18 2023 +0200 Fix autoscheduling support async/await and get’s more data to input commit 985d941 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Wed Jun 7 15:26:43 2023 +0200 v2.2.2 commit fe89381 Merge: dcb3015 35d4b0b Author: Pascal Kaufmann <kaufmae@me.com> Date: Mon Jun 5 12:21:46 2023 +0200 Merge pull request #563 from unchainedshop/extend-core-bookmark Add meta on bokkmark schema commit 35d4b0b Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Sun Jun 4 22:00:14 2023 +0300 Add meta on bokkmark schema commit dcb3015 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Wed May 31 15:15:29 2023 +0200 Fix #561 commit e3e7a2d Author: Pascal Kaufmann <pascal@unchained.shop> Date: Wed May 31 15:05:54 2023 +0200 Move defaults for env variables commit aa9863f Author: Pascal Kaufmann <pascal@unchained.shop> Date: Wed May 31 14:46:47 2023 +0200 Remove the need to default all the environments, opening the way to define defaults in the packages commit b3d7d89 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Fri May 19 14:55:31 2023 +0200 Fix types commit 98e807d Author: Pascal Kaufmann <pascal@unchained.shop> Date: Thu May 11 10:50:31 2023 +0200 Consistent workerId commit da9619e Author: Pascal Kaufmann <pascal@unchained.shop> Date: Tue May 9 13:44:32 2023 +0200 Restrict parallel running work items based on work adapter configuration It’s important for Unchained to process all import events in the order of how they are sent to the system, therefore we need to wait for the former to complete before we start a new BULK_IMPORT commit 4a4f487 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon May 8 21:15:27 2023 +0200 Downgrade formdata-node back to 4 commit 0dc08e4 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon May 8 21:06:31 2023 +0200 v2.2.0 commit 4c9a764 Merge: ee75d7e 86ab1c1 Author: Pascal Kaufmann <kaufmae@me.com> Date: Mon May 8 20:12:16 2023 +0200 Merge pull request #549 from unchainedshop/oauth2 Add oauth2 commit 86ab1c1 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon May 8 20:07:07 2023 +0200 Fix oAuthAccount and oAuthProvider types and filter the list of oAuthProviders so that those get returned that are active commit e1f66be Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon May 8 19:37:53 2023 +0200 Add provider type commit 9ddf9ab Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon May 8 17:12:12 2023 +0200 Fix oauth plugins to be compatible with changes commit 497a608 Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon May 8 14:56:27 2023 +0200 Fix inconsistent naming, refactor accounts commit d5f55ae Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Tue Apr 4 15:32:24 2023 +0300 Change oauth api names commit 97c9de7 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Thu Mar 23 20:19:56 2023 +0300 Fix typo commit 4867a47 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Wed Mar 22 20:54:10 2023 +0300 Fix OAuth typos commit 7e8fb44 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Thu Mar 16 18:40:57 2023 +0300 Improve refreshToken flow commit b88019c Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Wed Mar 15 23:31:37 2023 +0300 Fix unlink commit 67269e2 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Wed Mar 15 22:41:10 2023 +0300 Add oauth link and unlink mutation commit 5873995 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Wed Mar 15 16:32:29 2023 +0300 Use email to identify unique user oauth commit f33472f Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Wed Mar 8 14:45:44 2023 +0300 User can have multiple emails from a single oauth provider commit 0c3ce0d Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Wed Mar 8 14:11:05 2023 +0300 Use oauth providers email to check user when loging in with oauth commit d5b2fe6 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Sat Mar 4 23:23:18 2023 +0300 Remove debug code commit cf1a531 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Tue Feb 28 23:11:25 2023 +0300 Add linkedIn Oauth2 plugin commit 8d376a6 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Tue Feb 28 15:32:31 2023 +0300 Expose registered oauth adapter through shop info and get redirect url from client commit 8d306aa Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Mon Feb 27 20:43:23 2023 +0300 Safe access data from google commit 8ef2a27 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Mon Feb 27 18:56:04 2023 +0300 Make emails lower case for oauth commit 22d31f8 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Mon Feb 27 18:17:04 2023 +0300 Update Oauth plugins and get as much data from google as possible commit 2de4073 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Mon Feb 27 15:07:36 2023 +0300 Add refresh token interface and load avatar of user if available commit 6d05ab7 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Sun Feb 26 23:54:59 2023 +0300 Add support to revoke oauth2 access token commit 1e18931 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Sun Feb 26 23:37:12 2023 +0300 Separate getting and parsing access token interfaces commit 7ab5117 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Sun Feb 26 22:04:40 2023 +0300 Change oauth2 to account service and make Oauth2 a plugin commit a3e5099 Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Thu Feb 23 20:58:21 2023 +0300 Add google oauth service commit c50561c Author: Mikael Araya <mikaelaraya12@gmail.com> Date: Wed Feb 22 21:28:37 2023 +0300 Initial oauth2 module setup commit ee75d7e Author: Pascal Kaufmann <pascal@unchained.shop> Date: Mon May 8 13:38:53 2023 +0200 Improve error description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with Bookmark on a project I encountered this issues and fixed them on this PR
mutation.bookmarkdidn't acceptmetawhile it's possible to do the same thing withmutation.createBookmarkI think it would be great if it accepts tooBOOKMARK_UPDATEDevent but the registered bookmark module event isBOOKMARKS_UPDATE.other than the above issues current bookmark module is flexible and stable enough to use it for different application :)