Merge pull request #696 from mwarhaftig/issue665

Issue #665 - Relaxed Test & Page History to only secure-read.
unclebob · Mar 30, 2015 · 8021128 · 8021128
2 parents db14ad1 + 9b9fbfb
commit 8021128
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/.../FitNesse/SuiteAcceptanceTests/SuiteAuthenticationTests/AlwaysSecureOperation/content.txt b/.../FitNesse/SuiteAcceptanceTests/SuiteAuthenticationTests/AlwaysSecureOperation/content.txt
@@ -5,8 +5,6 @@
 !|operation is authenticated|
 |operation|
 |purgeHistory|
-|testHistory|
-|pageHistory|
 |shutdown|
 |renamePage|
 |deletePage|

diff --git a/...t/FitNesse/SuiteAcceptanceTests/SuiteAuthenticationTests/SecureReadOperations/content.txt b/...t/FitNesse/SuiteAcceptanceTests/SuiteAuthenticationTests/SecureReadOperations/content.txt
@@ -19,4 +19,6 @@
 |importAndView|
 |getPage|
 |packet|
+|testHistory|
+|pageHistory|
 
diff --git a/src/fitnesse/responders/testHistory/ExecutionLogResponder.java b/src/fitnesse/responders/testHistory/ExecutionLogResponder.java
@@ -6,9 +6,9 @@
 import java.util.Date;
 
 import fitnesse.FitNesseContext;
-import fitnesse.authentication.AlwaysSecureOperation;
 import fitnesse.authentication.SecureOperation;
 import fitnesse.authentication.SecureResponder;
+import fitnesse.authentication.SecureReadOperation;
 import fitnesse.html.template.HtmlPage;
 import fitnesse.html.template.PageTitle;
 import fitnesse.http.Request;
@@ -97,6 +97,6 @@ public void setResultsDirectory(File resultsDirectory) {
   }
 
   public SecureOperation getSecureOperation() {
-    return new AlwaysSecureOperation();
+    return new SecureReadOperation();
   }
 }
diff --git a/src/fitnesse/responders/testHistory/PageHistoryResponder.java b/src/fitnesse/responders/testHistory/PageHistoryResponder.java
@@ -13,9 +13,9 @@
 
 import util.FileUtil;
 import fitnesse.FitNesseContext;
-import fitnesse.authentication.AlwaysSecureOperation;
 import fitnesse.authentication.SecureOperation;
 import fitnesse.authentication.SecureResponder;
+import fitnesse.authentication.SecureReadOperation;
 import fitnesse.http.Request;
 import fitnesse.http.Response;
 import fitnesse.http.Response.Format;
@@ -187,6 +187,6 @@ private void prepareResponse(Request request) {
   }
 
   public SecureOperation getSecureOperation() {
-    return new AlwaysSecureOperation();
+    return new SecureReadOperation();
   }
 }
diff --git a/src/fitnesse/responders/testHistory/TestHistoryResponder.java b/src/fitnesse/responders/testHistory/TestHistoryResponder.java
@@ -7,8 +7,8 @@
 import org.apache.velocity.VelocityContext;
 
 import fitnesse.FitNesseContext;
-import fitnesse.authentication.AlwaysSecureOperation;
 import fitnesse.authentication.SecureOperation;
+import fitnesse.authentication.SecureReadOperation;
 import fitnesse.authentication.SecureResponder;
 import fitnesse.http.Request;
 import fitnesse.http.Response;
@@ -63,6 +63,6 @@ private boolean formatIsXML(Request request) {
   }
 
   public SecureOperation getSecureOperation() {
-    return new AlwaysSecureOperation();
+    return new SecureReadOperation();
   }
 }