-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install DataTables plugin #630 #742
Conversation
small refactoring
I'm not sure about this PR. What problem is it solving? I mean: it's a big chunk of javascript... |
…taTables Conflicts: src/fitnesse/wikitext/parser/ColoredSlimTable.java
I'd say it helps to create and maintain big test tables. Big tables doesn't mean 100+ rows. I showed that tool localy to my team and all of them (including devs and BAs) are liked it. |
…taTables Conflicts: src/fitnesse/wikitext/parser/ColoredSlimTable.java
I still have my doubts. I ran into some issue while testing this branch (e.g. pages like This might make for a nice plug-in, I'd say. For that we have to make some adjustments to FitNesse, but that would open the possibility to create plug-ins that can add behaviour to the front-end, which would be awesome. |
I don't feel comfortable with this. It would make for a nice plugin. I think it's better to make the UI more pluggable. |
Implementation of task #630
Sorry for large pull request.
Please, pay attention to changes made PropertyBasedPluginFeatureFactory. I'm not sure that I've done them in proper way.
I've run tests locally (ant.all task). I've got 48 test fails.
The messages were like "Method createPageWithContent[2] not found in fitnesse.fixtures.HashFixture." With different method and class names.
Code ready for review.
Tested in IE 11, Google Chrome 41.0.2272.118, Firefox 37.0.2, Opera 29.0.