Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install DataTables plugin #630 #742

Closed
wants to merge 9 commits into from

Conversation

DmitriyKartashov
Copy link
Contributor

Implementation of task #630

Sorry for large pull request.
Please, pay attention to changes made PropertyBasedPluginFeatureFactory. I'm not sure that I've done them in proper way.

I've run tests locally (ant.all task). I've got 48 test fails.
The messages were like "Method createPageWithContent[2] not found in fitnesse.fixtures.HashFixture." With different method and class names.

Code ready for review.
Tested in IE 11, Google Chrome 41.0.2272.118, Firefox 37.0.2, Opera 29.0.

@amolenaar
Copy link
Collaborator

I'm not sure about this PR. What problem is it solving? I mean: it's a big chunk of javascript...

…taTables

Conflicts:
	src/fitnesse/wikitext/parser/ColoredSlimTable.java
@DmitriyKartashov
Copy link
Contributor Author

I'd say it helps to create and maintain big test tables.
For example, with this tool it's easy to check is there a duplication of test cases or not.
The user can just enter the test case values in the "filter by" fields and see is such a case already created (and how many times).

Big tables doesn't mean 100+ rows.
For DDT if we have four columns as input data even if they are boolean it will require 16 test cases to cover all the flows. And what will be if they are, say, integers?...

I showed that tool localy to my team and all of them (including devs and BAs) are liked it.
It should mean something...

…taTables

Conflicts:
	src/fitnesse/wikitext/parser/ColoredSlimTable.java
@amolenaar
Copy link
Collaborator

I still have my doubts. I ran into some issue while testing this branch (e.g. pages like FitNesse.SuiteAcceptanceTests.SuiteResponderTests.SuiteRenameResponder.TestRenameChildPageWithSiblingReference appeared empty).

This might make for a nice plug-in, I'd say. For that we have to make some adjustments to FitNesse, but that would open the possibility to create plug-ins that can add behaviour to the front-end, which would be awesome.

@amolenaar
Copy link
Collaborator

I don't feel comfortable with this. It would make for a nice plugin. I think it's better to make the UI more pluggable.

@amolenaar amolenaar closed this Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants