Warning: Call-time pass-by-reference has been deprecated

[Tuckie]

My install doesn't seem too happy with $file->updateCMSFields(&$fields);

Warning: Call-time pass-by-reference has been deprecated in /srv/www/htdocs/intranet/kickassets/code/KickAssetAdmin.php on line 567

Seems to popup everywhere

[unclecheese]

What version of PHP? That ampersand shouldn't be there. There's no need to pass by reference in PHP5 if the variable is an object.

---

SilverStripe tips, tutorials, screencasts and more: http://www.leftandmain.com

Le Thursday, August 25, 2011 à 2:42 PM, Tuckie a écrit :

My install doesn't seem too happy with $file->updateCMSFields(&$fields);

Warning: Call-time pass-by-reference has been deprecated in /srv/www/htdocs/intranet/kickassets/code/KickAssetAdmin.php on line 567

Seems to popup everywhere

Reply to this email directly or view it on GitHub:
#1

[Tuckie]

Its php 5.2.14, and your ampersand: https://github.com/unclecheese/KickAssets/blob/master/code/KickAssetAdmin.php#L567

[unclecheese]

Fixed!

[Tuckie]

(Not a hard bug to fix, but...) Much thanks!

[MarcusDalgren]

Umm I just downloaded the latest version and there's still an ampersand in there. The code looks like this:
if(version_compare(PHP_VERSION, '5.3')) {
$file->updateCMSFields(&$fields);
}
else {
$file->updateCMSFields($fields);
}
I'm running version 5.2.11 but I'm still getting an error related to this. It's on line 600 in KickAssetAdmin.php.
Maybe it wasn't merged in yet?

[unclecheese]

5.3 wants it, 5.2 doesn't. That version compare should say >= 0.

Sent from my iPhone

On Aug 29, 2011, at 8:41 AM, smurkasreply@reply.github.com wrote:

Umm I just downloaded the latest version and there's still an ampersand in there. The code looks like this:
if(version_compare(PHP_VERSION, '5.3')) {
$file->updateCMSFields(&$fields);
}
else {
$file->updateCMSFields($fields);
}
I'm running version 5.2.11 but I'm still getting an error related to this. It's on line 600 in KickAssetAdmin.php.
Maybe it wasn't merged in yet?

Reply to this email directly or view it on GitHub:
#1 (comment)

[timsnadden]

This causes a fatal error for me in php 5.4.

Fatal error: Call-time pass-by-reference has been removed in /path/to/kickassets/code/KickAssetAdmin.php on line 684