Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sweep and prune collision detection #412

Merged
merged 12 commits into from Dec 4, 2023
Merged

Added sweep and prune collision detection #412

merged 12 commits into from Dec 4, 2023

Conversation

Gorkowski
Copy link
Collaborator

@Gorkowski Gorkowski commented Nov 30, 2023 •
edited

  • Add sweep and prune
  • test
  • update example

@Gorkowski Gorkowski marked this pull request as draft November 30, 2023 02:18
@sourcery-ai sourcery-ai bot mentioned this pull request Nov 30, 2023
Merged
@sourcery-ai
'Refactored by Sourcery' (#413)
ad5d4bf 
Co-authored-by: Sourcery AI <>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited

PR Preview Action v1.4.4
🚀 Deployed preview to https://uncscode.github.io/particula/pr-preview/pr-412/
on branch gh-pages at 2023-12-04 00:38 UTC

@Gorkowski Gorkowski self-assigned this Nov 30, 2023
@Gorkowski Gorkowski marked this pull request as ready for review November 30, 2023 20:11
@Gorkowski
Copy link
Collaborator Author

@ngmahfouz

I don't have a test for the function particle_pairs.full_sweep_and_prune_simplified,
It needs some logic fixing before it can replace the manual loop of paritcle_pairs.full_sweep_and_prune

I was going to push that for the future unless the problem/solution jumps out at you.

ngmahfouz
ngmahfouz approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@ngmahfouz ngmahfouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just raise an impl error (or any error) if someone is using that function 😉

particula/lagrangian/collisions.py Outdated Show resolved Hide resolved
particula/lagrangian/particle_pairs.py Outdated Show resolved Hide resolved
particula/lagrangian/particle_pairs.py Show resolved Hide resolved
particula/lagrangian/particle_pairs.py Outdated Show resolved Hide resolved
particula/lagrangian/particle_pairs.py Show resolved Hide resolved
@ngmahfouz
Copy link
Collaborator

Looks good; you should set the automerge thing on :)

@Gorkowski Gorkowski added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 1964fe6 Dec 4, 2023
9 checks passed
@Gorkowski Gorkowski deleted the Gorkowski/issue411 branch December 4, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngmahfouz ngmahfouz ngmahfouz approved these changes

Assignees

@Gorkowski Gorkowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gorkowski @ngmahfouz