test: delete api token handler test #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichenqin
requested changes
Sep 10, 2023
| import { DeleteApiTokenCommandHandler } from './delete-api-token.command.handler' | ||
| import { None, Some } from 'oxide.ts' | ||
|
|
||
| describe('APITokenStrategy', () => { |
There was a problem hiding this comment.
Suggested change
| describe('APITokenStrategy', () => { | |
| describe('test DeleteApiTokenCommandHandler', () => { |
| userId = new UserId('user123') | ||
| }) | ||
| test('Delete api token success', async () => { | ||
| cls.get.calledWith('user.userId').mockReturnValue('user123') |
There was a problem hiding this comment.
cls 和 repo 所有的 mock 都应该放在 beforeEach 里面
| }) | ||
| test('Delete api token success', async () => { | ||
| cls.get.calledWith('user.userId').mockReturnValue('user123') | ||
| apiToken.userId = userId |
There was a problem hiding this comment.
常量的声明不用放这里，也不要放beforeEach，你可以直接在最外层的作用域 const
nichenqin
force-pushed
the
delete-api-token-test
branch
from
beeb5a1
to
45364e1
Compare
nichenqin
temporarily deployed
to
delete-api-token-test - undb PR #1499
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.