-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: delete api token handler test #1499
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
packages/cqrs/src/commands/delete-api-token/delete-api-token.command.handler.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import { IClsService, ClsStore, User, UserId } from '@undb/core' | ||
import { ApiToken, IApiTokenRepository } from '@undb/openapi' | ||
import { MockProxy, mock } from 'vitest-mock-extended' | ||
import { DeleteApiTokenCommand } from './delete-api-token.command' | ||
import { DeleteApiTokenCommandHandler } from './delete-api-token.command.handler' | ||
import { None, Some } from 'oxide.ts' | ||
|
||
describe('APITokenStrategy', () => { | ||
let repo: MockProxy<IApiTokenRepository> | ||
let cls: MockProxy<IClsService<ClsStore>> | ||
let command: DeleteApiTokenCommand | ||
let handler: DeleteApiTokenCommandHandler | ||
let apiToken: ApiToken | ||
let userId: UserId | ||
|
||
beforeEach(() => { | ||
repo = mock<IApiTokenRepository>() | ||
cls = mock<IClsService<ClsStore>>() | ||
apiToken = new ApiToken() | ||
command = new DeleteApiTokenCommand({ apiTokenId: 'apiTokenIdString' }) | ||
handler = new DeleteApiTokenCommandHandler(repo, cls) | ||
userId = new UserId('user123') | ||
}) | ||
test('Delete api token success', async () => { | ||
cls.get.calledWith('user.userId').mockReturnValue('user123') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cls 和 repo 所有的 mock 都应该放在 beforeEach 里面 |
||
apiToken.userId = userId | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 常量的声明不用放这里,也不要放beforeEach,你可以直接在最外层的作用域 const |
||
repo.findOneById.mockResolvedValue(Some(apiToken)) | ||
await handler.execute(command) | ||
expect(repo.findOneById).toHaveBeenCalledWith(command.apiTokenId) | ||
expect(repo.deleteOneById).toHaveBeenCalledWith(command.apiTokenId) | ||
}) | ||
|
||
test('Delete api token faild', async () => { | ||
cls.get.calledWith('user.userId').mockReturnValue('user123') | ||
apiToken.userId = userId | ||
repo.findOneById.mockResolvedValue(None) | ||
await handler.execute(command) | ||
expect(repo.deleteOneById).not.toHaveBeenCalled() | ||
}) | ||
|
||
test('Delete api token error', async () => { | ||
cls.get.calledWith('user.userId').mockReturnValue('user321') | ||
apiToken.userId = userId | ||
repo.findOneById.mockResolvedValue(Some(apiToken)) | ||
await expect(handler.execute(command)).rejects.toThrowErrorMatchingInlineSnapshot( | ||
'"cannot delete api token belongs to other user"', | ||
) | ||
expect(repo.deleteOneById).not.toHaveBeenCalled() | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.