Added the styles for the new gutenberg-based search widget #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to gutenberg-search-form
bacoords
approved these changes
Mar 13, 2022
IanDelMar
reviewed
Mar 13, 2022
| .wp-block-search { | ||
| .wp-block-search__label { | ||
| @if variable-exists('bootstrap4') { | ||
| @include sr-only(); |
There was a problem hiding this comment.
I think @extend would give smaller CSS.
| @if variable-exists('bootstrap4') { | ||
| @include sr-only(); | ||
| } @else { | ||
| @include visually-hidden(); |
There was a problem hiding this comment.
I think @extend would give smaller CSS.
IanDelMar
reviewed
Mar 13, 2022
| @extend .input-group; | ||
|
|
||
| .wp-block-search__input { | ||
| @extend .form-control; |
IanDelMar
reviewed
Mar 13, 2022
| @@ -190,10 +194,17 @@ a.skip-link { | |||
| margin-left: 0; | |||
| } | |||
|
|
|||
| @extend .btn-primary; | |||
| @if variable-exists('bootstrap4') { | |||
| @include button-variant( $primary, $primary ); | |||
There was a problem hiding this comment.
@extend .btn-primary; gives marginally smaller CSS
IanDelMar
reviewed
Mar 14, 2022
| margin-left: 0; | ||
| } | ||
|
|
||
| @if variable-exists('bootstrap4') { |
There was a problem hiding this comment.
Can be simplified to
@include button-variant( $primary, $primary );
@if variable-exists('bootstrap4') {
border-top-left-radius: 0;
border-bottom-left-radius: 0;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Types of changes
Checklist:
develop.develop.composer cs:checkhas passed locally.composer lint:phphas passed locally.Related Issues or Roadmap requests
Further comments