New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search block widget #1675
Fix search block widget #1675
Conversation
@bacoords this PR needs a review. |
Great @IanDelMar - I'm going to pull in the latest BS version from #1821 and then test all the style fixes |
@bacoords I'll resolve the conflicts that will then occur. |
@bacoords I resolved the conflicts and updated the PHPStan baseline. I'll work on the "no value type specified in iterable" errors at some point in the future. |
This is great- I'd never even played with the new search widget. I thought only the 'legacy' search widget was available. |
Description
This PR
Motivation and Context
#1647 tried to fix #1533. However, it added a lot of CSS, makes
<label>
permanently invisible and introduced unexpected styles.Reduction of CSS file size
Bootstrap 4 example
Before this PR
After this PR
Types of changes
Checklist:
develop
.develop
.composer cs:check
has passed locally.composer lint:php
has passed locally.Related Issues or Roadmap requests
Related to #1647
Fixes #1533
Further comments