Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2044] Update README #1303

Merged
merged 4 commits into from Mar 15, 2022
Merged

[UNDERTOW-2044] Update README #1303

merged 4 commits into from Mar 15, 2022

Conversation

fl4via
Copy link
Member

@fl4via fl4via commented Mar 11, 2022

@fl4via
[UNDERTOW-2044] Update README
d7605f1 
Signed-off-by: Flavia Rainone <frainone@redhat.com>
@fl4via fl4via added the enhancement Enhances existing behaviour or code label Mar 11, 2022
rhusar
rhusar approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good to me, just squash the commits (since they don't bring additional value as per best SCM practices).

@fl4via
Copy link
Member Author

fl4via commented Mar 15, 2022

@rhusar Thanks for having a look :-) ! That was the plan. I just kept them separated because I wanted Tom to see clearly that I submitted the changes he asked for. I'm going to merge and squash now.

@fl4via fl4via merged commit f593657 into undertow-io:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhusar rhusar rhusar approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code
Projects
None yet
Milestone
No milestone
2 participants
@fl4via @rhusar