UNDERTOW-652 MCMPHandler#handleRequest() does not work with IPv6 addr… #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhatlapa can you please test this before we merge this? |
rhusar
force-pushed
the
UNDERTOW-652
branch
2 times, most recently
from
ce6434d
to
d64a6d1
Compare
|
This fix causes NPE when starting mod_cluster filter |
|
@rhatlapa Good catch, thanks, fixed now. Sounds like this is missing test coverage... |
|
Checked the new fix and it looks good. |
|
Great, thanks, the modcluster counterpart is: modcluster/mod_cluster#168 |
|
Because it relies on multicast it I don't really know any way to write tests for it that will work in all environments. |
|
|
||
| public int getManagementPort() { | ||
| return managementPort; | ||
| public InetSocketAddress getManagementSocketAddress() { |
There was a problem hiding this comment.
We should not really be changing API's in a point release
There was a problem hiding this comment.
Ideally yes, buts its really bad :-( and I am not sure how else to do this cleanly.. also all the getters are used internally by the implementation so there should be no harm.
There was a problem hiding this comment.
I guess you just meant to keep them around as deprecated.. I can do that.
|
That is the mod_cluster API I think that is OK to change, we have also a changing mod_proxy API in Apache HTTPD and don't think people are using the undertow mod_cluster API outside undertow,.. |
|
I merged this with a minor change to preserve binary compat |
|
Linux Build 1768 outcome was FAILURE using a merge of 7a4e318 Failed tests |
|
@stuartwdouglas @rhusar this should be reverted as it causes 161 test failures. |
|
@ctomc Thanks for checking into this, but these are really broken tests. We have done bunch of changes with Stuart and now the testsuite should run clean again. |
|
@rhusar great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…esses
https://issues.jboss.org/browse/UNDERTOW-652