ECS automatic deployment #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
port being what's used with the load balancer
version it's running
kaihendry
requested review from
eddiemoore and
nbiton
and removed request for
eddiemoore
nbiton
reviewed
Dec 26, 2017
| @@ -9,6 +9,10 @@ before_install: | |||
| - export PATH="$HOME/.meteor:$PATH" | |||
| - pip install --user awscli | |||
| - export PATH=$PATH:$HOME/.local/bin | |||
| - curl -o $HOME/.local/bin/ecs-cli https://s3.amazonaws.com/amazon-ecs-cli/ecs-cli-linux-amd64-latest && chmod +x $HOME/.local/bin/ecs-cli | |||
| - aws configure set profile.lmb-dev.aws_access_key_id $AWS_ACCESS_KEY_ID | |||
There was a problem hiding this comment.
Later, when we merge this stuff with staging, we'll need to use the conditional which prevents the script from trying to access the AWS env vars on pull request CI builds.
There was a problem hiding this comment.
Oh, that's a point. I guess this should all be setup in the deploy stage only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current deploys on any commit for testing purposes. We can limit easily to master later. Won't pass CI since it doesn't get access to AWS_SECRET_ACCESS_KEY!
Has a longer timeout: aws/amazon-ecs-cli#401 (comment)
Still unanswered questions: