Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed updating internal note #601

Merged
merged 2 commits into from Apr 28, 2016

Conversation

agnessa
Copy link
Contributor

@agnessa agnessa commented Apr 28, 2016

https://www.pivotaltracker.com/story/show/118548989

The bug would only manifest itself where a nomenclature_comment object existed before the nomenclature change. Where none existed, it would be created with the internal note correctly, but if it existed before, the changes to the text would not save on tc.save - it needed an extra nomenclature_comment.save

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 80.202% when pulling f80fb70 on fixed_updating_internal_note into c355451 on nomenclature_changes.

@Levia Levia merged commit f80fb70 into nomenclature_changes Apr 28, 2016
@Levia Levia deleted the fixed_updating_internal_note branch April 28, 2016 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants