Support Wagtail v3 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmoreton
changed the title
Closed
William-Blackie
suggested changes
Oct 28, 2022
There was a problem hiding this comment.
Hey @nickmoreton,
this looks great, a couple of little tweaks and this should be good to go!
Thanks - Will.
| if WAGTAIL_VERSION >= (3, 0): | ||
| from wagtail.models import Site | ||
| from wagtail.admin.panels import FieldPanel | ||
| else: |
There was a problem hiding this comment.
Hey @nickmoreton,
I think this a good start but it removes the functionality of wagtail <2.0. We could do something like this instead;
if WAGTAIL_VERSION >= (3, 0):
from wagtail.models import Site
from wagtail.admin.panels import FieldPanel
elif WAGTAIL_VERSION >= (2, 0):
from wagtail.core.models import Site
from wagtail.admin.edit_handlers import FieldPanel
else:
from wagtail.wagtailcore.models import Site
from wagtail.wagtailadmin.edit_handlers import FieldPane
| else: | ||
| from wagtail.wagtailadmin.edit_handlers import InlinePanel |
| else: | ||
| from wagtail.wagtailcore.models import Site | ||
| from wagtail.contrib.wagtailsitemaps.views import sitemap | ||
| from wagtail.contrib.sitemaps.views import sitemap |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade package to support Wagtail 3