Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparing nodes of different types for equality #302

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Fix comparing nodes of different types for equality #302

merged 2 commits into from
Nov 25, 2019

Conversation

sunesimonsen
Copy link
Member

No description provided.

@sunesimonsen sunesimonsen marked this pull request as ready for review November 25, 2019 18:07
@sunesimonsen sunesimonsen force-pushed the ssimonsen/fix-comparing-dom-nodes-of-diffent-types branch from 9424b6b to 9e2ab35 Compare November 25, 2019 18:10
@coveralls
Copy link

coveralls commented Nov 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1279

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 93.586%
Totals Coverage Status
Change from base Build 1270: -0.07%
Covered Lines: 690
Relevant Lines: 720
💛 - Coveralls

@sunesimonsen sunesimonsen force-pushed the ssimonsen/fix-comparing-dom-nodes-of-diffent-types branch from 9e2ab35 to 1c32fbe Compare November 25, 2019 18:16
papandreou
papandreou approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@sunesimonsen sunesimonsen merged commit 103a8e9 into master Nov 25, 2019
@sunesimonsen sunesimonsen deleted the ssimonsen/fix-comparing-dom-nodes-of-diffent-types branch November 25, 2019 22:21
@sunesimonsen
Copy link
Member Author

Released as unexpected-dom@4.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papandreou papandreou papandreou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sunesimonsen @coveralls @papandreou