Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't break when a function has its own custom #toString #415

Merged
merged 1 commit into from
Aug 14, 2017
Merged

Don't break when a function has its own custom #toString #415

merged 1 commit into from
Aug 14, 2017

Conversation

papandreou
Copy link
Member

@papandreou papandreou commented Aug 14, 2017 •
edited
Loading

I ran into a problem with chance-generators instances being inspected as function ( /*...*/ ) { /*...*/ }. Turns out it's because chance-generators defines a custom toString.

The enclosed fix handles that by getting the toString from Function.prototype instead.

@papandreou papandreou force-pushed the fix/functionInspectionWithCustomToString branch from 8fdf7a1 to 653b5e4 Compare August 14, 2017 08:38
sunesimonsen
sunesimonsen approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@sunesimonsen sunesimonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@papandreou papandreou merged commit 8dbafee into master Aug 14, 2017
@papandreou papandreou deleted the fix/functionInspectionWithCustomToString branch August 14, 2017 08:51
@papandreou
Copy link
Member Author

Released in 10.33.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunesimonsen sunesimonsen sunesimonsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@papandreou @sunesimonsen