Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint JavaScript snippets in the documentation #480

Merged
merged 30 commits into from
Jan 22, 2019
Merged

Commits on Jan 10, 2019

  1. Configuration menu
    Copy the full SHA
    c78fb3f View commit details
    Browse the repository at this point in the history
  2. Disable the no-unused-vars and no-undef rules

    Avoid errors from the snippets being linted independently
    papandreou committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    990d2a8 View commit details
    Browse the repository at this point in the history
  3. eslint --fix --ext js,md .

    papandreou committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    b7a747c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5017ac1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    26dce84 View commit details
    Browse the repository at this point in the history
  6. Convert ```js#flags to preceding HTML comments

    perl -pi -e 'BEGIN{undef $/;} s/```js#async:true/<!-- async:true -->\n```js/g;' `find documentation -name '*.md'`
    perl -pi -e 'BEGIN{undef $/;} s/```js#evaluate:false/<!-- evaluate:false -->\n```js/g;' `find documentation -name '*.md'`
    perl -pi -e 'BEGIN{undef $/;} s/```js#freshExpect:true/<!-- freshExpect:true -->\n```js/g;' `find documentation -name '*.md'`
    perl -pi -e 'BEGIN{undef $/;} s/```js#skipBrowser:true/<!-- skipBrowser:true -->\n```js/g;' `find documentation -name '*.md'`
    papandreou committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    ac3ed54 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b24062a View commit details
    Browse the repository at this point in the history
  8. eslint --fix --ext js,md .

    papandreou committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    0c80ee8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    74f3cea View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8857859 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. Configuration menu
    Copy the full SHA
    0180745 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e4d707 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1538c0f View commit details
    Browse the repository at this point in the history
  4. Use the old js#evaluate:false syntax for snippets that aren't valid J…

    …avaScript
    
    So that eslint-plugin-markdown can't tell they're JavaScript 😼
    papandreou committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    1ed057a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    52f9acf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    67714b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2019

  1. Configuration menu
    Copy the full SHA
    02546a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    77f4386 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. Merge branch 'master' into feature/lint-markdown

    * master:
      Updated the changelog
      11.0.1
      Build unexpected.js
      Remove ad hoc disabling of the no-unexpected-multiline eslint rule
      Whoops, two of those had to be Buffer.alloc
      Fix lint
      new Buffer => Buffer.from
      Add mocha env to the eslint config
      eslint --fix .
      Add standard and prettier/standard
      Replace eslint-config-pretty-standard with eslint-config-prettier
      Disable no-unexpected-multiline so standard and prettier don't battle each other
      eslint --fix .
      Fix expect.promise#inspect tests
      Avoid deprecation warnings in node.js 10 because we have methods called inspect
    papandreou committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    80a7f09 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into feature/lint-markdown

    * master:
      .eslintrc.js: Remove unnecessary parserOptions
    papandreou committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    c1eb08f View commit details
    Browse the repository at this point in the history
  3. Fix new lint errors from #578

    papandreou committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    3209f4a View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. perl -pi -e 's/<!-- (.*)-->/<!-- unexpected-markdown $1-->/g;' `find …

    …documentation -name '*.md'`
    papandreou committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    cd98e4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0761da9 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Configuration menu
    Copy the full SHA
    ce148f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Configuration menu
    Copy the full SHA
    4f41fbf View commit details
    Browse the repository at this point in the history
  2. Disable import/no-extraneous-dependencies only where necessary instea…

    …d of in documentation/.eslintrc
    papandreou committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    89f17f5 View commit details
    Browse the repository at this point in the history
  3. Regain syntax highlighting of ```js blocks that don't parse

    Now that we can combine eslint and unexpected-markdown directives:
    
    <!-- unexpected-markdown evaluate:false -->
    <!-- eslint-skip -->
    papandreou committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    10d2711 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    96caa8a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Configuration menu
    Copy the full SHA
    1090605 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c861ab8 View commit details
    Browse the repository at this point in the history